Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update multicomponent tutorial #54

Merged
merged 9 commits into from
Aug 9, 2024

Conversation

BrandeisPatrick
Copy link
Contributor

@BrandeisPatrick BrandeisPatrick commented Jun 30, 2024

Description

added a tutorial for multicomponent (multicomponent_tutorial.rst)

Updates

  • added command input for MixtureBuilder()
  • added files for the tutorial of generating a mixed solvent box (naphthalene in acetonitrile/water)

What to do next

all todos are included in the 'Note for AutoSolvate Developers' sections in the multicomponent_tutorial.rst file

  • Please make command input for MulticomponentSolventBoxBuilder() class and MulticomponentParamsBuilder() class.

  • test if the download link in .rst file works properly

  • Please test if '-m' and '-s' command fully support both xyz and pdb file inputs which means if someone provides xyz file, the Multicomponent module will convert the xyz file into pdb file using openbable.

  • Please implement a way to allow user to specify the solute charges and multiplicities.

     The idea case is allow user to provide a .inp document for the Multicomponent to read.
    
     For example autosolvate boxgen_multicomponent -m naphthalene_neutral.xyz -s solvents.inp
    
     The solvents.inp file will look like this:
        #xyzfile, charge, multiplicities
        water.xyz 0 1
        acetonitrile.xyz 0 1
    
  • Please implement a way to allow user to use TIP3P water and other solvents AMBER already has force field parameters for.

  • There are many flags in startmulticomponent() not working.

    -o, --output. Currently, we can not specify the output names. Please implement this feature and make sure it works.
    
    -r, --srunuse. Not implemented at all
    
    -e, --gaussianexe. Not sure if we need this flag.
    
    -d, --gaussiandir. Not sure if we need this flag.
    
    -a, --amberhome. Not sure if we need this flag
    
    -l, --solventoff. MixtureBuilder() can read solvent.off file, I have not implmented and tested this flag
    
    -p, --solventfrcmod Same as above.
    
    -g --chargefitting. Currently only support bcc. Please implement RESP charge fitting method.
    
  • It seems the autosolvate mdrun command will not work if you use nohup. Please test and try to fix this issue.

@ffangliu ffangliu merged commit cf138cf into autosolvate_merge Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants